Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-219249718
@nvazquez sorry for the late review,
I could point just 2 typos on Javadoc and some variables with the
underscore (would be nice to change those variables names, but they are nothing
serious).
Great work, I can't see anything wrong, the code LGTM.
**Note:** I am just given my feedback, I don't want to run over the
@koushik-das review, it would be nice to check his comment about
_NFS_VERSION_DETAILS_KEY_ at the "BaseImageStoreDriverImpl" class. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
