Github user koushik-das commented on the pull request:

    https://github.com/apache/cloudstack/pull/1518#issuecomment-219692208
  
    @nvazquez I am not too familiar with the VMware specific code, rest of the 
code looks ok.
    
    Also a comment on #1361 when this feature was initially added. NFS version 
is stored in image_store_details table and needs to be manually added using 
some sql script. A better way would be to use ConfigKey to expose the 
configuration. There will be some work involved to include image store as a 
scope for specifying configuration. May be you can fix it in subsequent PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to