I think QPD(ecode) is now OK; it handles lowercase hex and rejects invalid characters.
Base64Decode handles valid input OK, and rejects some invalid input, but could perhaps do with tweaking to handle PAD characters better. At present it treats an embedded PAD as the end of input (as per Codec) but maybe it would be better to only allow 1 or 2 PADs at the end? On 19 March 2013 19:50, sebb <seb...@gmail.com> wrote: > There's one other issue - Commons Codec does not support soft line > breaks in quoted printable decoding. > As far as I know, those are required. > > On 19 March 2013 19:46, Matt Benson <gudnabr...@gmail.com> wrote: >> Yes, you can shade only the classes needed. Getting rid of code that does >> the same thing across multiple Commons components seems a worthwhile use of >> time IMO and really shouldn't represent any more work than fixing the >> broken classes in [fileupload]. Also, no triage is required to figure out >> how to implement this solution, as opposed to the case with fixing buggy >> code. >> Matt >> >> >> On Tue, Mar 19, 2013 at 2:30 PM, sebb <seb...@gmail.com> wrote: >> >>> -1 if this results in a huge increase in size of the jar. >>> If shading can extract only the required classes, that might be OK, >>> but it seems like a lot of work when the code already works for valid >>> input. >>> >>> I think the only outstanding problems are the way the decoders handle >>> invalid input. >>> >>> >>> On 19 March 2013 19:25, Maurizio Cucchiara <mcucchi...@apache.org> wrote: >>> >> Why not depend on [codec] and shade, then? >>> > +1 >>> > >>> > Maurizio Cucchiara >>> > >>> > --------------------------------------------------------------------- >>> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> > For additional commands, e-mail: dev-h...@commons.apache.org >>> > >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
