Are you saying that the jar in the bin zip includes classes that are instrumented for use with Cobertura? If so, that would be a -1 indeed.
Gary On Fri, Nov 27, 2015 at 1:23 PM, Phil Steitz <phil.ste...@gmail.com> wrote: > Sigs, hashes, contents look good except for dreaded error below. > Ant and maven build works fine on OSX 1.7. Did not test 1.6 or 1.8 > yet because of two blockers > > 1. The binary jar appears to have the dreaded Coberta disease. > When I hack the ant build to run the tests against the release jar, > I get > Testsuite: org.apache.commons.io.ByteOrderMarkTestCase > Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec > > Caused an ERROR > net/sourceforge/cobertura/coveragedata/TouchCollector > java.lang.NoClassDefFoundError: > net/sourceforge/cobertura/coveragedata/TouchCollector > at > org.apache.commons.io.ByteOrderMark.__cobertura_init(ByteOrderMark.java) > at org.apache.commons.io.ByteOrderMark.<clinit>(ByteOrderMark.java) > at > > org.apache.commons.io.ByteOrderMarkTestCase.<clinit>(ByteOrderMarkTestCase.java:32) > at java.lang.Class.forName0(Native Method) > at java.lang.Class.forName(Class.java:191) > Caused by: java.lang.ClassNotFoundException: > net.sourceforge.cobertura.coveragedata.TouchCollector > at java.net.URLClassLoader$1.run(URLClassLoader.java:366) > at java.net.URLClassLoader$1.run(URLClassLoader.java:355) > at java.security.AccessController.doPrivileged(Native Method) > at java.net.URLClassLoader.findClass(URLClassLoader.java:354) > at java.lang.ClassLoader.loadClass(ClassLoader.java:425) > at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308) > at java.lang.ClassLoader.loadClass(ClassLoader.java:358) > > We need to somehow definitely get rid of this thing so it does not > corrupt release binaries. > > The NOTICE file also needs to have copyright data updated. > > There are a couple of checkstyle and findbugs errors that should > either be suppressed or fixed. > > So I am -1 on the package as it is. > > Thanks for stepping up to do the release and sorry to have to -1. > > Phil > > On 11/23/15 10:31 AM, Kristian Rosenvold wrote: > > We have fixed quite a few bugs and added some significant > > enhancements since commons-io was released, > > so I would like to release commons-io 2.5 > > > > Foo 2.5 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/io/ (svn revision > 11266) > > > > Maven artifacts are here: > > > https://repository.apache.org/content/repositories/orgapachecommons-1123 > > > > Details of changes since 2.4 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/io/RELEASE-NOTES.txt > > > http://people.apache.org/~krosenvold/commons-io-2.5-RC1/changes-report.html > > > > I have tested this with JDK 1.6, 1.7 and 1.8. > > > > The tag is here: > > > https://svn.apache.org/repos/asf/commons/proper/io/tags/commons-io-2.5-RC1 > > (r1715890) > > > > Site: > > http://people.apache.org/~krosenvold/commons-io-2.5-RC1/ > > (note some *relative* links are broken and the 2.5 directories are > > not yet created - these will be OK once the site is deployed) > > > > Clirr Report (compared to 2.4): > > > http://people.apache.org/~krosenvold/commons-io-2.5-RC1/clirr-report.html > > > > > > RAT Report: > > > http://people.apache.org/~krosenvold/commons-io-2.5-RC1/rat-report.html > > > > KEYS: > > https://www.apache.org/dist/commons/KEYS > > > > Please review the release candidate and vote. > > This vote will close no sooner that 72 hours from now, i.e. after > > 19:00 CET 26-March 2015 > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thanks! > > > > > > Kristian > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
