On Mon, May 22, 2017 at 1:10 PM, Stephen Colebourne <scolebou...@joda.org> wrote:
> I took a stab at adding module-info.java to [lang]: > https://github.com/jodastephen/commons-lang/commit/ > 5d5dd6809eeef90ea2b6245c0d0a488fb917e30a > > Since the maven-bundle-plugin isn't working, I had to use antrun to > copy the module-info.class file out and back in again. A gross hack. > > There are two key findings: > > 1) [lang] currently depends on java.desktop. ie. the whole of Swing > and AWT. This is because `AbstractCircuitBreaker` uses > `PropertyChangeListener`. This was a big problem for the JDK too, and > they removed 6 JDK methods in order to avoid dependencies like this. > > My recommendation is to remove the change listener methods. > Potentially this needs to be done aggressively in 3.7, which implies > deprecation in v3.6. > Don't you mean 4.0 since changing: - AbstractCircuitBreaker.addChangeListener(PropertyChangeListener) - AbstractCircuitBreaker.removeChangeListener(PropertyChangeListener) would break BC? Gary > > > 2) The DateUtilsTest does not pass for me on JDK 9. There are 6 test > failures, something to do with time-zones causing the BASE_DATE to be > set incorrectly. These failures occur without the module-info code on > JDK 9, so they need fixing anyway. The test does pass on JDK 8, so it > is a JDK 9 issue (Idon't have the time to really figure out what is > wrong sadly). > > thanks > Stephen > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459> JUnit in Action, Second Edition <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021> Spring Batch in Action <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
