[ X ] +1 Release it. I'm OK with the lazy vote from the other thread, or with this vote process. Both work fine for me.
And fantastic work! Build from tag passing with `mvn clean test site` on: Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T20:58:13+13:00) Maven home: /opt/apache-maven-3.5.2 Java version: 1.8.0_151, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-8-oracle/jre Default locale: en_NZ, platform encoding: UTF-8 OS name: "linux", version: "4.4.0-104-generic", arch: "amd64", family: "unix" Reports look good. Verified signatures of binaries in dist, and maven staging repo, and everything looks good. Amazing work on the test coverage. The few maven-plugins I work so far had a very small amount of tests to be honest. Had a look at the code and it looks good too. Minor nit-picks but no blockers IMO: 1) In pom.xml, the website is http://commons.apache.org/proper/commons-release-plugin/, but in README.md the website links are possibly broken. For example, the homepage link is pointing to https://commons.apache.org/proper/commons-commons-release-plugin, and the javadocs also contains similar URL. (notice the part commons-commons in the URL) Is that a typo or a problem in some script that generates that README file? 2) In NOTICE.txt, it says Apache Commons Build Plugin, with a Copyright from 2008 to 2018. Shouldn't it say Apache Commons Release Plugin, with a Copyright from 2018 only for now? 3) In my working copy (checked out the tag) I have LICENSE *and* LICENSE.txt. Do we need both files? assembly/xml files seem to include LICENSE.txt, so I assume LICENSE can be removed? Or the xml files could be updated perhaps... 4) There's a typo in src/changes/release-notes.vm On the first paragraph, the component name is spelled as "commons-release-plgin" (missing u in plugin). 5) Some .java files contain the @author tags. I think the convention now is to drop the author tags from source files, and instead rely on the SCM history only? 6) Few StringBuffers in some Mojos that perhaps could be replaced by StringBuilders? Again, just nit-picks. Release looks good, +1 and kudos!!! Cheers Bruno ________________________________ From: Rob Tompkins <chtom...@apache.org> To: Commons Developers List <dev@commons.apache.org> Sent: Thursday, 11 January 2018 3:50 PM Subject: [VOTE] Release Commons Release Plugin 1.0 base on RC1 Hello all, This is a [VOTE] for releasing Apache commons-release-plugin 1.0 (from RC1). Tag name: commons-release-plugin-1.0-RC1 (signature can be checked from git using 'git tag -v') Tag URL: https://git-wip-us.apache.org/repos/asf?p=commons-release-plugin.git;a=tag;h=6b05b8bee894ad471c5e1eda979550b344c21020 Commit ID the tag points at: 2f48a0ebd07318419b4d92a7e7b594f4fca47428 Site: https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/site.zip Distribution files (committed at revision 24125): https://dist.apache.org/repos/dist/dev/commons/commons-release-plugin/ Distribution files hashes (SHA1): commons-release-plugin-1.0-bin.tar.gz (SHA1: 02a0e034ed89c87e620ceaf4aef879121d4b87de) commons-release-plugin-1.0-bin.zip (SHA1: e0c4cf6449f6baab4c52c98c1e577512486d8fba) commons-release-plugin-1.0-src.tar.gz (SHA1: e48b67b70b154b7dc69914752814512225024504) commons-release-plugin-1.0-src.zip (SHA1: bc9a6c847899b2700e5873c4ac1a8d983476b255) These are the Maven artifacts and their hashes: commons-release-plugin-1.0-javadoc.jar (SHA1: bc2cdfa56f55ee538087038a1194ea2789863ca9) commons-release-plugin-1.0-sources.jar (SHA1: eb20eec8580fd5a2633bd2822e951d57043d3d4e) commons-release-plugin-1.0-test-sources.jar (SHA1: 61aa51b44025ced470b0e21b19a3eb65e154df1f) commons-release-plugin-1.0-tests.jar (SHA1: a81f42e01ca77a86048e07963d4ea496a69251f6) commons-release-plugin-1.0.jar (SHA1: 2897ab01d2e8460d100d196db55e53b2a1bab73e) commons-release-plugin-1.0.pom (SHA1: 2bcc663eb212f9a2233acc21773ef80883ac0881) KEYS file to check signatures: http://www.apache.org/dist/commons/KEYS Maven artifacts: https://repository.apache.org/content/repositories/orgapachecommons-1302 Please select one of the following options[1]: [ ] +1 Release it. [ ] +0 Go ahead; I don't care. [ ] -0 There are a few minor glitches: ... [ ] -1 No, do not release it because ... This vote will be open at least 72 hours, i.e. until 2018-01-14T03:00:00Z (this is UTC time). -------- Cheers, -Rob [1] http://apache.org/foundation/voting.html --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
