Looking at commons-collections, commons-digester and commons-validator at the moment. Will look at commons-vfs next regarding getting to JUnit v4, then adding assertThrows afterwards.
What are views about adding `<maven.compiler.testSource>1.8</maven.compiler.testSource>`? I've not done it at the moment as suspect builds are not setup for that and will fail etc. But it does mean I need to add; final ThrowingRunnable testMethod = new ThrowingRunnable() { public void run() { // The Code } }; assertThrows(ExceptionClass.class, testMethod); instead of just; final Executable testMethod = () -> // The Code assertThrows(ExceptionClass.class, testMethod); John On Wed, 14 Oct 2020 at 22:07, Gary Gregory <garydgreg...@gmail.com> wrote: > > For my money: > > - I REALLY like assertThrows > - Might as well go to JUnit 5 if you feel up for it. > - BUT: My biggest pain point ATM is that while Commons VFS is on JUnit 4, > most tests are still JUnit 3 (TestCase) classes that won't run properly > from Eclipse. > > So I would really like help getting VFS to at least be off of anything > JUnit 3-like and at least to JUnit 4 but that won't stop a release which I > hope to do within a week or two. > > TY! > Gary > > On Wed, Oct 14, 2020 at 3:56 PM Romain Manni-Bucau <rmannibu...@gmail.com> > wrote: > > > Hi John, > > > > Would be +1 from me if: > > > > 1. It does not require to move from junit4 to junit5 (no gain IMHO) > > 2. Test goes further than a Exception rule or @Test(expected) > > > > If both points are matched it makes sense to me, otherwise it will likely > > add more issues from my experience. > > > > > > Le mer. 14 oct. 2020 à 21:40, John Patrick <nhoj.patr...@gmail.com> a > > écrit : > > > > > before i waste time looking at upgrading tests... > > > > > > any objections if i upgrade tests to use assertAll and assertThrows > > > introduced in JUnit jupiter? > > > > > > I see it as less tech debt removal and I'm happy to spend time doing > > > the upgrade which I've done from maybe several projects now. Just > > > don't want to get to raising PR and them being rejected, which I feel > > > happens with everything I try to help out with related to commons > > > projects at the moment... > > > > > > cheers, > > > john > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org