Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-commonsrdf/pull/25#discussion_r85503001
--- Diff:
api/src/test/java/org/apache/commons/rdf/api/AbstractRDFTermFactoryTest.java ---
@@ -208,8 +172,8 @@ public void testCreateIRIRelative() throws Exception {
// be possible to resolve to an absolute IRI)
try {
factory.createIRI("../relative");
- } catch (UnsupportedOperationException | IllegalArgumentException
ex) {
- Assume.assumeNoException(ex);
+ } catch (IllegalArgumentException ex) {
+ Assume.assumeNoException("Relative IRIs not supported - ignore
this test", ex);
--- End diff --
Agreed - perhaps a factory would support relative IRIs but would make them
absolute - e.g. the factory could have its own base URI (as would be the case
when parsing). Removed test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
