Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-commonsrdf/pull/25#discussion_r85507044
--- Diff: api/src/main/java/org/apache/commons/rdf/api/BlankNodeOrIRI.java
---
@@ -19,7 +19,7 @@
/**
* This interface represents the {@link RDFTerm}s that may be used in the
- * subject position of an RDF-1.1 {@link Triple}, including {@link
BlankNode}
+ * subject position of an RDF-1.1 {@link Triple}, that is {@link BlankNode}
--- End diff --
"either" is stronger - meaning that we say they are distinct. (Which I
think they are)
if you agree we can then also say in `RDFTerm` that it also must be a
`IRI`, `BlankNode` or `Literal`. Perhaps using _SHOULD_ so that evil people
can still make their `SparqlVariable` if they so wish - knowing well that this
would break various stuff.
In `RDFTerm` I added:
* Instances of RDFTerm SHOULD be an {@link IRI}, {@link BlankNode} or
* {@link Literal}.
and in `BlankNodeOrIRI`:
> * Instances of BlankNodeOrIRI SHOULD be a {@link BlankNode} or an {@link
IRI}.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
