Github user stain commented on a diff in the pull request:
https://github.com/apache/incubator-commonsrdf/pull/25#discussion_r85506150
--- Diff:
rdf4j/src/test/java/org/apache/commons/rdf/rdf4j/Rdf4JRDFTermFactoryTest.java
---
@@ -18,19 +18,19 @@
package org.apache.commons.rdf.rdf4j;
import org.apache.commons.rdf.api.AbstractRDFTermFactoryTest;
-import org.apache.commons.rdf.api.RDFTermFactory;
+import org.apache.commons.rdf.api.RDF;
import org.junit.Assume;
public class Rdf4JRDFTermFactoryTest extends AbstractRDFTermFactoryTest {
@Override
- public RDFTermFactory createFactory() {
- return new RDF4JFactory();
+ public RDF createFactory() {
+ return new RDF4J();
}
@Override
public void testInvalidLiteralLang() throws Exception {
- Assume.assumeTrue("Sesame doesn't check Lang strings",false);
+ Assume.assumeTrue("RDD4J doesn't check Lang strings",false);
--- End diff --
Fixed. Also renamed `*RDFTermFactoryTest` to `*RDFTest`
I changed to `@Ignore` in `JsonLdRdfTest`, but I can't use @Ignore here as
the parent test method has `@Test(expected = IllegalArgumentException.class)`
and somehow the `@Ignore` is not honoured - at least in Eclipse.
Using `Assume.assumeTrue` is still recognized as "test skipped".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
