That sounds good. For the automated tests, it would seem that running all of them should be the default since it takes basically no extra effort to do so. If that sounds reasonable, how about a tweak on your tweak:
- When we say "run the test suites" this includes all automated tests in mobile-spec, manual tests in mobile-spec that might be affected by the change, and any platform-specific unit tests (i.e., cordova-android/test, cordova-ios/CordovaLibTests, etc.) On Jun 17, 2013, at 10:31 AM, Andrew Grieve <agri...@chromium.org> wrote: > Marcel, I like your wiki suggestion. I think it'll capture Joe's concern to > just change: > > - When we say "run the test suites" this includes the automated tests in > mobile-spec, the manual tests in mobile-spec and any platform-specific unit > tests (i.e., cordova-android/test, cordova-ios/CordovaLibTests, etc.) > > to: > > - When we say "run the test suites" this includes all automated and manual > tests in mobile-spec that might be affected by the change, and any > platform-specific unit tests (i.e., cordova-android/test, > cordova-ios/CordovaLibTests, etc.) > > > On Thu, Jun 13, 2013 at 7:58 PM, Marcel Kinard <cmarc...@gmail.com> wrote: > >> On Jun 13, 2013, at 11:16 AM, Joe Bowser <bows...@gmail.com> wrote: >> >>> No offense, but have you ever run all the manual tests? Doing this is a >>> time consuming process and is unnecessary in most cases. >> >> (It takes a lot to offend me, you're fine.) >> >> Agree on being time consuming, compared to the automated tests. And >> sometimes it's not entirely clear when a manual test succeeds/fails. >> >> Yeah, the full manual tests are probably overkill on a per-commit basis. >> So when should they get run, just as a final pass when the RC is cut? Or >> some subset of "applicable" ones that intersect with the function that is >> being touched in a commit? Or some other trigger? >> >>> You can write what you want on the wiki but >>> it doesn't mean the people writing the code will follow it (myself >>> included). >> >> My goal here is not to put verbage on the wiki, but to get consensus on >> the standard procedure on this topic. The reason I'm asking these questions >> is it sounds like they haven't been talked about at this level of detail >> before, otherwise I would be getting schooled right now. ;-) >> >> -- Marcel Kinard
