I think validation should be part of VOTE, actually as the first step to testing a release. No sense testing a proposed release if its not known to be the right thing.
We have a coho command that does verify-archive and I usually start testing with running that, perhaps now we need to add a coho verify-package, or something? -Michal On Tue, Sep 2, 2014 at 2:15 PM, Carlos Santana <csantan...@gmail.com> wrote: > I was just trying to validate what we put in npmjs.org matches what is > located on [1] > > If both matches then it doesn't matter how you do your testing with npm or > the content of [1]. > > I'm guessing that everyone is testing using [1] and not apache git checkout > hash from this email. But if they match to the same bits then who cares, we > are all testing the same thing. Get the picture :-) > > Seriously now, On what step of the process do we validate npmjs.org > against > [1]? After vote has pass? or do it with with a "rc" and then make it > "latest" on npm? > > [1]: https://dist.apache.org/repos/dist/dev/cordova/CB-7383/rc/ > > > > On Tue, Sep 2, 2014 at 1:54 PM, Steven Gill <stevengil...@gmail.com> > wrote: > > > Looks like CLI VERSION file is incorrect :( Didn't get updated. Also > looks > > like the zip i uploaded for the CLI got generated incorrectly. Need to > take > > a deeper look. > > > > I don't see cordova-js 3.6.0-dev Version file anywhere. > > > > I'm also running into an issue with firefoxos testing. Looks like it > can't > > find shelljs module. > > > > > > > > On Tue, Sep 2, 2014 at 10:47 AM, Michal Mocny <mmo...@chromium.org> > wrote: > > > > > .. Looks like cordova-cli still has a VERSION file set to 3.5.0-0.2.4. > > Is > > > it even used? > > > > > > .. and cordova-cli deps on cordova-lib which deps on cordova-js which > has > > > VERSION file set to 3.6.0-dev. > > > > > > > > > On Tue, Sep 2, 2014 at 1:42 PM, Michal Mocny <mmo...@chromium.org> > > wrote: > > > > > > > We could ask Apache folk for clarification, but if I understand the > > > > requirements for release process correct, I think publishing an rc > and > > > > voting on it would be totally acceptable provided that: > > > > > > > > (a) *exactly* the tarball that went up to RC is used as the final > > > release, > > > > so that signatures match. At the very least I think that would mean > to > > > > leaving the "-rc#" portion out of all the "version" key (and any > > VERSION > > > > files). > > > > (b) We don't advertise to users that this is a release they should > > > consume. > > > > > > > > It looks like Steven has done this. > > > > > > > > -Michal > > > > > > > > > > > > On Tue, Sep 2, 2014 at 1:26 PM, Steven Gill <stevengil...@gmail.com> > > > > wrote: > > > > > > > >> Actually, I like Carlos suggestion. > > > >> > > > >> We have already been publishing to npm under the RC tag for testing > > (not > > > >> releasing to public but just for dev testing). > > > >> > > > >> The last few releases you could go npm install cordova@rc and that > > > would > > > >> download the RC version of cordova that we were voting on. > > > >> > > > >> I went ahead and published all of the platforms + lib + plugman + js > > > >> (everything we are voting on) to npm under an rc tag. So npm install > > > >> cordova-android@rc would grab version 3.6.0. > > > >> > > > >> The easiest way to test is to now go npm install cordova@rc. No > need > > to > > > >> --usegit anymore. > > > >> > > > >> The --usegit method would require you to checkout the tags in > > > cordova-lib, > > > >> cordova-js, npm link them, go to cli, npm link them, etc. > > > >> > > > >> -Steve > > > >> > > > >> > > > >> On Tue, Sep 2, 2014 at 10:23 AM, Parashuram Narasimhan (MS OPEN > TECH) > > < > > > >> panar...@microsoft.com> wrote: > > > >> > > > >> > Agree with Jesse. If you still want to test it, I tried doing it > > with > > > a > > > >> > private npm registry, and changed my npm to pick up from that > > > registry. > > > >> I > > > >> > did not see a lot of value added though. I did this when I was > > playing > > > >> with > > > >> > the idea of using npm to use plugins. > > > >> > > > > >> > -----Original Message----- > > > >> > From: Jesse [mailto:purplecabb...@gmail.com] > > > >> > Sent: Tuesday, September 2, 2014 10:21 AM > > > >> > To: dev@cordova.apache.org > > > >> > Subject: Re: [Vote] 3.6.0 Cadence Release > > > >> > > > > >> > We cannot post to npm without the vote passing. There is a bunch > of > > > >> crazy > > > >> > overhead tag bs we could do, but then we would not be voting on > the > > > >> final > > > >> > released binaries. > > > >> > > > > >> > Just test with --usegit > > > >> > > > > >> > > > > >> > > > > >> > @purplecabbage > > > >> > risingj.com > > > >> > > > > >> > > > > >> > On Tue, Sep 2, 2014 at 6:47 AM, Carlos Santana < > > csantan...@gmail.com> > > > >> > wrote: > > > >> > > > > >> > > I see cordova cli rc on npm, I want to test it using npm but I > get > > > >> > errors. > > > >> > > Maybe cordova-lib should be also posted to npm but not make it > > > latest > > > >> > > until we release. > > > >> > > > > > >> > > I get this errors: > > > >> > > > > > >> > > $ npm install cordova@rc > > > >> > > > > > >> > > npm ERR! Error: version not found: cordova-lib@0.21.8 > > > >> > > > > > >> > > > > > >> > > On Tue, Sep 2, 2014 at 9:29 AM, Bryan Higgins < > > > br...@bryanhiggins.net > > > >> > > > > >> > > wrote: > > > >> > > > > > >> > > > +1 > > > >> > > > > > > >> > > > - Verified signatures and hashes for cordova-blackberry > > > >> > > > - Verified sha1 match tag 3.6.0 > > > >> > > > - Ran mobile spec on various BB10 devices and OS versions > > > >> > > > > > > >> > > > Steve - I added you as an owner for cordova-blackberry10 on > npm. > > > The > > > >> > > > cordova-blackberry package should probably be unpublished. > > > >> > > > > > > >> > > > > > > >> > > > On Tue, Sep 2, 2014 at 1:15 AM, Archana Naik > > > >> > > > <naik.arch...@gmail.com> > > > >> > > > wrote: > > > >> > > > > > > >> > > > > vote +1 > > > >> > > > > Verified amazon-fireos bundle, signatures and hashes. > > > >> > > > > > > > >> > > > > When are we planning to publish it to npm? > > > >> > > > > > > > >> > > > > > > > >> > > > > On Mon, Sep 1, 2014 at 2:40 PM, Sergey Grebnov (Akvelon) < > > > >> > > > > v-seg...@microsoft.com> wrote: > > > >> > > > > > > > >> > > > > > I vote +1: > > > >> > > > > > * Verified signatures and hashes for cordova-cli, > > cordova-lib, > > > >> > > > > > cordova-plugman, cordova-windows, cordova-wp8 > > > >> > > > > > * Verified sha1s match tags for cordova-cli, cordova-lib, > > > >> > > > > cordova-plugman, > > > >> > > > > > cordova-windows, cordova-wp8 > > > >> > > > > > * Run Medic tests for Windows and Windows Phone 8 > > > >> > > > > > * Tested Android build on Windows > > > >> > > > > > * Tested Windows platform manually > > > >> > > > > > building and running app with VS2012 (msbuild > > > >> > > > > > 4.0)/VS2013(msbuild > > > >> > > > > 12.0) > > > >> > > > > > -win and -phone switches > > > >> > > > > > support of target platform settings (config.xml) > > > >> > > > > > support of custom icons and splash screen images > > > >> > > > > > > > > >> > > > > > Thx! > > > >> > > > > > Sergey > > > >> > > > > > -----Original Message----- > > > >> > > > > > From: Steven Gill [mailto:stevengil...@gmail.com] > > > >> > > > > > Sent: Saturday, August 30, 2014 5:35 AM > > > >> > > > > > To: dev@cordova.apache.org > > > >> > > > > > Subject: [Vote] 3.6.0 Cadence Release > > > >> > > > > > > > > >> > > > > > Please review and vote on this 3.6.0 Cadence Release. > > > >> > > > > > > > > >> > > > > > Release issue: > > https://issues.apache.org/jira/browse/CB-7383 > > > >> > > > > > > > > >> > > > > > Repos ready to be released have been published to > > > >> > > > > > dist/dev: > > > https://dist.apache.org/repos/dist/dev/cordova/CB-7383 > > > >> > > > > > > > > >> > > > > > The packages were published from their corresponding git > > tags: > > > >> > > > > > cordova-android: 3.6.0 (014327c59a) > > > >> > > > > > cordova-ios: 3.6.0 (3a92b2dbf0) > > > >> > > > > > cordova-blackberry: 3.6.0 (ed435bfc9e) > > > >> > > > > > cordova-windows: 3.6.0 (cdb292f4a3) > > > >> > > > > > cordova-wp8: 3.6.0 (a879f5258b) > > > >> > > > > > cordova-firefoxos: 3.6.0 (9ab176f855) > > > >> > > > > > > > > >> > > > > > cordova-ubuntu: 3.6.0 (bff472e4c2) > > > >> > > > > > cordova-amazon-fireos: 3.6.0 (4e94c6d198) > > > >> > > > > > cordova-js: 3.6.0 (906b34c0a4) > > > >> > > > > > cordova-mobile-spec: 3.6.0 (27053f7dd8) > > > >> > > > > > cordova-app-hello-world: 3.6.0 (65a2171a19) > > > >> > > > > > > > > >> > > > > > cordova-cli: 3.6.0-0.2.8 (01cb09f2d1) > > > >> > > > > > cordova-lib: 0.21.8 (14670ec9b5) > > > >> > > > > > cordova-plugman: 0.22.5 (29488fce7e) > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > Upon a successful vote I will upload the archives to > dist/, > > > >> > > > > > publish > > > >> > > > them > > > >> > > > > > to NPM, and post the corresponding blog post. > > > >> > > > > > > > > >> > > > > > Voting guidelines: > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting > > > >> > > .md > > > >> > > > > > > > > >> > > > > > Voting will go on for a minimum of 72 hours. > > > >> > > > > > > > > >> > > > > > I vote +1: > > > >> > > > > > * Ran coho audit-license-headers over the relevant repos > > > >> > > > > > * Used `license-checker` to ensure all dependencies have > > > >> > > > > Apache-compatible > > > >> > > > > > licenses > > > >> > > > > > * Ensured continuous build was green when repos were > tagged > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > -- > > > >> > > Carlos Santana > > > >> > > <csantan...@gmail.com> > > > >> > > > > > >> > > > > >> > > > > > > > > > > > > > > > > > -- > Carlos Santana > <csantan...@gmail.com> >
