I've sent a PR with changes: https://github.com/apache/cordova-android/pull/124
Could anyone pls. review? --------------- Best regards, Vladimir -----Original Message----- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Monday, 22 September, 2014 17:48 To: dev Subject: Re: New project <PATH> vs. <NAME> I see no issues with hardcoding the main activity name. On Mon, Sep 22, 2014 at 6:06 AM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > So do we agree to proceed with hardcoded name for android main > activity here ('CordovaApp' for example), or we still need to > implement additional parameter to cli, platform scripts and config.xml ? > --------------- > Best regards, Vladimir > > -----Original Message----- > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] > Sent: Tuesday, September 16, 2014 10:08 AM > To: dev@cordova.apache.org > Subject: RE: New project <PATH> vs. <NAME> > > IMHO this could be a solution. > > It seems that <android:name> for main activity is not visible anywhere > outside of application (I mean Google Play, app details, etc.) and so > it can be made static. The main restriction here is that > <android:name> for activity can't be changed after publishing of the > app [1], [2] > > Anybody correct me if I'm wrong. > > [1] > http://developer.android.com/guide/components/activities.html#Declarin > g > [2] > http://android-developers.blogspot.ru/2011/06/things-that-cannot-chang > e.html > > --------------- > Best regards, Vladimir > > -----Original Message----- > From: Parashuram Narasimhan (MS OPEN TECH) > [mailto:panar...@microsoft.com] > Sent: Saturday, 13 September, 2014 0:10 > To: dev@cordova.apache.org > Subject: RE: New project <PATH> vs. <NAME> > > To standardize, could we not need a param name, and set the Main class > name in Android to something static always - say CordovaApp? The only > problem would be in debugging where the activity name would be same. > > -----Original Message----- > From: Josh Soref [mailto:jso...@blackberry.com] > Sent: Friday, September 12, 2014 12:02 PM > To: dev@cordova.apache.org > Subject: Re: New project <PATH> vs. <NAME> > > I thought the initial plan was to just standardize on a safe name, and > worry about the other variation later... > > On 9/12/14, 2:59 PM, "Vladimir Kotikov (Akvelon)" > <v-vlk...@microsoft.com> > wrote: > > >Bumping this again. > > > >Can anyone pls. review following PRs: > > https://github.com/apache/cordova-cli/pull/192 > > https://github.com/apache/cordova-lib/pull/84 > > https://github.com/apache/cordova-android/pull/118 > > > >This is an implementation for CB-7231 “Provide more control over > >CordovaProjectName vs CordovaAppName” [1] These changes adds a new > >option for cli and Android tooling - --projectname that allow to > >user to specify main class name, different from application name. > >This is necessary when application name contains non-ASCII characters > >since ADK tools can't properly handle this situation. > > > >Implementation is for Android only, since we don't see any problems > >with other platforms. > > > >I think we need to decide should it be a core option that can be > >defined via CLI command or in config.xml or just an android > optio/preference. > >And if it is a core, do we need it for all platforms, or for android only? > > > >------------- > >Best regards, Vladimir > > > > > >-----Original Message----- > >From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] > >Sent: Friday, September 5, 2014 5:24 PM > >To: dev@cordova.apache.org > >Subject: RE: New project <PATH> vs. <NAME> > > > >Hi all! > > > >I’ve started working on implementation for CB-7231 “Provide more > >control over CordovaProjectName vs CordovaAppName” [1]. > > > >Draft implementation for android is ready, you can review it here: > > https://github.com/apache/cordova-cli/pull/192 > > https://github.com/apache/cordova-lib/pull/84 > > https://github.com/apache/cordova-android/pull/118 > > > >1.General changes in cli/lib > > * ProjectName can be specified via --projectname option for cli > >create command; > > * It's written to config.xml into <projectname> element. > > Another option - store Project name into <name> element's > >attribute > >- <name projectname="ProjName">AppName<name> > > > >2. Android part of implementation: > > * ProjectName can be specified for bin/create script via > >--projectname option; > > * If specified, used for main activity/class name replacement; > > > >3. Android_parser in cli > > * update_from_config() method handles <projectname> element in > >config.xml during prepare step and renames main class and changes > >activity name in manifest according to <projectname> value. > > * in case of <projectname> element removal main class and activity > >name are remains unchanged from last rename. > > > >For discussion: > >1. Currently I use <projectname> element to store ProjectName at > >config.xml? Another possible option - use <name projectname=""> > >approach, like Carlos proposed. > >2. Currently if ProjectName becomes undefined (<projectname> element > >is > >removed) main class file and activity are not being renamed back to > >app name. > > > >Thoughts? > > > >And just a PS. Could anyone pls. give me permissions at JIRA so I can > >assign issues to myself? > > > >[1] https://issues.apache.org/jira/browse/CB-7231 > > > >--------------- > >Best regards, Vladimir > >
