I think we'll also need to finish with the whitelist changes & have both the legacy and new-way whitelist plugins released before we can do a 4.0.0 release (otherwise you wouldn't be able to write an app that hits the network)
On Wed, Feb 25, 2015 at 12:41 PM, Andrew Grieve <[email protected]> wrote: > Alright, branch is merged in and I fixed a couple other things I noticed > broken in the native test app (back button & background color). I've also > gone ahead with removing the LinearLayout and confirmed that both maps and > nativepagetransitions plugins are not affected at all. > > Might as well add in the key signing tweaks that have been agreed upon. I > can do that today. > > Would like your input on: > Deprecated show/hide customView > - At first I thought this was just view twiddling for video on old > androids that was not meant to be exposed > - I see now though that there is custom back button logic for it > - and that the maps plugin uses it to go fullscreen > - so I'm thinking let's not deprecate. > > We're also still waiting for a tools release to happen that will set 3.7.1 > as the default platform (don't have cycles to do it this week myself) > > > > > > > > On Tue, Feb 24, 2015 at 7:39 PM, Joe Bowser <[email protected]> wrote: > >> I can't come up with any. Let's not delay the release on that. So, other >> than the platform docs, we should be good to go, right? >> >> On Thu Feb 19 2015 at 11:42:40 AM Andrew Grieve <[email protected]> >> wrote: >> >> > Thanks for the quick review. I'll have a look through your comments. >> Now's >> > a good time to change names, so feel free to suggest alternatives. >> > >> > On Thu, Feb 19, 2015 at 1:32 PM, Joe Bowser <[email protected]> wrote: >> > >> > > I've done a quick read of the pull request and left some comments in >> > > there. I'm in Salt Lake this week, so I haven't had a chance to >> really >> > > test this pull request yet, but while I'm not in love with the naming >> > > convention used, it looks mostly OK. >> > > >> > > On Thu Feb 19 2015 at 11:19:51 AM Andrew Grieve <[email protected] >> > >> > > wrote: >> > > >> > > > They would need to do similar to the PR for xwalk. It's actually a >> lot >> > > less >> > > > code now to implement a custom engine, so I think it makes geckoview >> > much >> > > > more feasible. >> > > > >> > > > The embedded case (I'm guessing you mean layout xml?) is one of the >> > unit >> > > > tests. Have a look here: >> > > > https://github.com/agrieve/cordova-android/blob/engine/ >> > > > test/src/org/apache/cordova/test/CordovaWebViewTestActivity.java >> > > > >> > > > If we delete LinearLayout, we just pass the WebView itself to >> > > > setContentView(). It will still have a FrameLayout as a parent >> (which >> > is >> > > > the unchangeable root View of all Activities) >> > > > >> > > > For reference, here's now NativePageTransitions inserts their own >> > Layout: >> > > > https://github.com/Telerik-Verified-Plugins/ >> > NativePageTransitions/blob/ >> > > > master/src/android/NativePageTransitions.java#L74 >> > > > >> > > > On Thu, Feb 19, 2015 at 1:01 PM, Joe Bowser <[email protected]> >> wrote: >> > > > >> > > > > So, I know that XWalk is the only production-ready WebView right >> now, >> > > but >> > > > > what would other third party providers need to implement/change >> for >> > > their >> > > > > webviews to work? Also, I'm not clear how the embedded >> CordovaWebView >> > > use >> > > > > case would work in this scenario. If we delete the LinearLayout, >> > what >> > > do >> > > > > we attach our view for the default use case? >> > > > > >> > > > > On Thu Feb 19 2015 at 10:39:59 AM Andrew Grieve < >> > [email protected]> >> > > > > wrote: >> > > > > >> > > > > > I've finished playing with third-party plugins. If anyone else >> > wants >> > > to >> > > > > > have fun with them, use --thirdpartyplugins in >> createmobilespec.js, >> > > and >> > > > > > then find the manual test for them. >> > > > > > >> > > > > > TLDR - most compiled/worked fine. Two that interacted with >> Views a >> > > lot >> > > > > had >> > > > > > lots of compile errors, but in the end I don't think there's a >> good >> > > way >> > > > > to >> > > > > > fix them on our end. >> > > > > > >> > > > > > I've also taken some time to try and eliminate copy & paste >> between >> > > > > > AndroidWebView and XWalkWebView. I'd love to get some feedback >> on >> > the >> > > > > > changes (and hopefully get them in). More info /w PRs here: >> > > > > > >> > > > > > https://issues.apache.org/jira/browse/CB-8510 >> > > > > > >> > > > > > Another thing that came out of looking at these plugins is that >> > they >> > > > add >> > > > > in >> > > > > > their own Layout, or have logic to handle various parent layout. >> > > So... >> > > > I >> > > > > > think we'd be fine (and should) delete our top-level >> LinearLayout. >> > > > > Plugins >> > > > > > and embedders can easily add in layouts if they want. >> > > > > > >> > > > > > Still waiting on a tools release for 3.7.1. >> > > > > > Still need to update platform docs for 4.0.0 >> > > > > > >> > > > > > But... I think that's it! (unless I'm missing something) >> > > > > > >> > > > > > >> > > > > > >> > > > > > On Wed, Feb 4, 2015 at 10:11 PM, Ian Clelland < >> > > [email protected]> >> > > > > > wrote: >> > > > > > >> > > > > > > On Wed, Feb 4, 2015 at 7:58 PM, Fu, Junwei < >> [email protected]> >> > > > > wrote: >> > > > > > > >> > > > > > > > What are the test cases don't work for Crosswalk? I'd like >> to >> > do >> > > > > > whatever >> > > > > > > > I can to help. >> > > > > > > > >> > > > > > > >> > > > > > > So, Crosswalk 10 (and, I believe, 11) work great for Cordova. >> > There >> > > > is >> > > > > a >> > > > > > > failing test in File Transfer, though, that appears to be a >> > > threading >> > > > > > issue >> > > > > > > causing a NPE deep inside of OkHTTP. >> > > > > > > >> > > > > > > It's very similar to a bug we solved almost a year ago: >> > > > > > > https://issues.apache.org/jira/browse/CB-6378, except that >> it's >> > > > > > happening >> > > > > > > in a different method, and while the last time, the cause was >> > > obvious >> > > > > > > (connections opened on one thread, and closed on another), >> this >> > > time >> > > > > > > everything *should* be happening on the same thread. >> > > > > > > >> > > > > > > I've just created >> https://issues.apache.org/jira/browse/CB-8431 >> > if >> > > > you >> > > > > > > want >> > > > > > > to take a look. I haven't had the chance to really dig into >> where >> > > the >> > > > > > error >> > > > > > > is coming from yet, but I'll take a closer look tomorrow. >> > > > > > > >> > > > > > > Ian >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > > >> > > > > > > > -----Original Message----- >> > > > > > > > From: [email protected] [mailto:[email protected]] On >> Behalf >> > > Of >> > > > > > Andrew >> > > > > > > > Grieve >> > > > > > > > Sent: Thursday, February 05, 2015 3:43 AM >> > > > > > > > To: dev >> > > > > > > > Subject: Re: [DISCUSS] Cordova-Android 4.0.0 Release >> > > > > > > > >> > > > > > > > On Wed, Feb 4, 2015 at 2:25 PM, Joe Bowser < >> [email protected]> >> > > > > wrote: >> > > > > > > > >> > > > > > > > > OK, so since we're using e-mail to do a sprint, here's >> where >> > I >> > > > > think >> > > > > > > > > we're at so far. >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > - Ian's been working on getting crosswalk 10 working and >> is >> > > > hitting >> > > > > > > > > some FileTransfer crash issues. >> > > > > > > > > (Apparently Crosswalk-11 works? Ian, what's happening with >> > > this?) >> > > > > > > > > - Mobilespec really should be passing, let's investigate >> and >> > > fix >> > > > > > > > > plugins / tests if they are the issues. >> > > > > > > > > >> > > > > > > > > Has anyone done this yet? >> > > > > > > > > >> > > > > > > > Don't think so. >> > > > > > > > >> > > > > > > > > >> > > > > > > > > - Android's update script is not preserving artifacts of >> > > > <framework >> > > > > > > > > type="gradleReference"/> (hoping to work on this today) >> > > > > > > > > >> > > > > > > > > Did you get around to doing this? >> > > > > > > > > >> > > > > > > > Done! >> > > > > > > > >> > > > > > > > > >> > > > > > > > > - *LinearLayoutSoftKeyboardDetect - delete it!* >> > > > > > > > > >> > > > > > > > > It's apparently already gone on Master. >> > > > > > > > > >> > > > > > > > Done! >> > > > > > > > >> > > > > > > > > >> > > > > > > > > - Ensure that our gradle support is to the point where >> > plugins >> > > > can >> > > > > > > > > target android-sdk-provided libs (play services & -compat >> > libs) >> > > > > > > > > >> > > > > > > > > What needs to be done here? Is there a JIRA issue for >> this? >> > > > > > > > > >> > > > > > > > Done! Needs a tools release. >> > > > > > > > Haven't tested how bad the error messages are if you don't >> have >> > > > them >> > > > > > > > installed though. That seems like a can-be-done-after thing >> > (e.g. >> > > > If >> > > > > > the >> > > > > > > > error message sucks, we could: before build, pre-scan for >> > > existence >> > > > > of >> > > > > > > them >> > > > > > > > in the SDK directly.) >> > > > > > > > >> > > > > > > > > >> > > > > > > > > - Make CordovaActivity not implement CordovaInterface, but >> > > > instead >> > > > > > > > > provide CordovaInterface via an inner class (to solidify >> that >> > > you >> > > > > > > > > can't cast the activity to CordovaInterface and expect >> that >> > to >> > > > > work - >> > > > > > > > > some used to do this but I think we've cleaned it all up >> now) >> > > > > > > > > >> > > > > > > > done! >> > > > > > > > >> > > > > > > > >> > > > > > > > > >> > > > > > > > > I know there's a vote pending for 3.7.1, and we still need >> > > people >> > > > > to >> > > > > > > > > vote on that (I'll get around to it before the voting >> period >> > > > ends), >> > > > > > > > > but I'm wondering how close we are to getting a 4.0.0 vote >> > > > > happening? >> > > > > > > > > >> > > > > > > > >> > > > > > > > I'd like to do a bit more work with playing with third party >> > > > plugins >> > > > > in >> > > > > > > > mobilespec before we vote to release. Right now many of them >> > > don't >> > > > > > > compile, >> > > > > > > > and I think the main reason is that CordovaWebView is not a >> > view. >> > > > > > > Planning >> > > > > > > > on writing up a report of how many popular plugins break, >> and >> > how >> > > > bad >> > > > > > it >> > > > > > > is >> > > > > > > > to fix them. >> > > > > > > > >> > > > > > > > Also need to update embedder's guide in docs (maybe create >> an >> > > > > > > android-4.0.0 >> > > > > > > > branch?) >> > > > > > > > Also need to do a plugins release for splashscreen (will >> start >> > > > > > shortly). >> > > > > > > > >> > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > > On Tue Feb 03 2015 at 7:20:29 PM Fu, Junwei < >> > > [email protected] >> > > > > >> > > > > > > wrote: >> > > > > > > > > >> > > > > > > > > > Crosswalk engine have been tested in mobile-spec and >> owned >> > > > > > > > > > functionality tests with Crosswalk-11, and it was our >> plan >> > to >> > > > be >> > > > > > > > > > released. I request a PR in here >> > > > > > > > > > https://github.com/MobileChromeApps/cordova- >> > > > > > > > > > crosswalk-engine/pull/17. >> > > > > > > > > > >> > > > > > > > > > Thanks, >> > > > > > > > > > Junwei. >> > > > > > > > > > >> > > > > > > > > > -----Original Message----- >> > > > > > > > > > From: [email protected] [mailto:[email protected]] On >> > > Behalf >> > > > > Of >> > > > > > > > > > Andrew Grieve >> > > > > > > > > > Sent: Wednesday, February 04, 2015 3:53 AM >> > > > > > > > > > To: dev >> > > > > > > > > > Subject: Re: [DISCUSS] Cordova-Android 4.0.0 Release >> > > > > > > > > > >> > > > > > > > > > And, of course, for your FileTransfer change :P >> > > > > > > > > > >> > > > > > > > > > I just last night finished up the fixing of <framework >> > > > > > custom=false> >> > > > > > > > > > for gradle-based builds, so we're certainly nearing the >> > > finish >> > > > > line >> > > > > > > > > > for 4.0.0 known issues. >> > > > > > > > > > >> > > > > > > > > > Of the list from before, only remaining are: >> > > > > > > > > > >> > > > > > > > > > - Ian's been working on getting crosswalk 10 working >> and is >> > > > > hitting >> > > > > > > > > > some FileTransfer crash issues. >> > > > > > > > > > - Mobilespec really should be passing, let's investigate >> > and >> > > > fix >> > > > > > > > > > plugins >> > > > > > > > > / >> > > > > > > > > > tests if they are the issues. >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > On Tue, Feb 3, 2015 at 2:46 PM, Darryl Pogue < >> > > > > [email protected]> >> > > > > > > > > wrote: >> > > > > > > > > > >> > > > > > > > > > > I just remembered that there should be a plugins >> release >> > > > before >> > > > > > > > > > > Android 4.0.0 goes out because of the moving of the >> > > > > splashscreen >> > > > > > > > > > > logic out of the platform and into the plugin. As far >> as >> > I >> > > > can >> > > > > > > > > > > tell, that's still unreleased. >> > > > > > > > > > > >> > > > > > > > > > > >> > > ------------------------------------------------------------ >> > > > > > ------ >> > > > > > > > > > > --- To unsubscribe, e-mail: dev-unsubscribe@cordova. >> > > > apache.org >> > > > > > > > > > > For additional commands, e-mail: >> > > [email protected] >> > > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > ------------------------------ >> > ------------------------------ >> > > > > > -------- >> > > > > > > > > > - To unsubscribe, e-mail: dev-unsubscribe@cordova. >> > apache.org >> > > > > > > > > > For additional commands, e-mail: >> > [email protected] >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > >> > >
