Julio, You are a committer now :-), you can go ahead and merge if it's ready.
Any manual or auto tests you can add or the one that exist today enough? What you mean by once it's merge you can check? You mean for any other uses cases in addition of the ones you already fixed - Carlos @csantanapr > On Nov 6, 2015, at 5:56 AM, julio cesar sanchez <jcesarmob...@gmail.com> > wrote: > > I was writing a mail with the same subject, luckily I saw your message > before sending. > > I have this PR for statusbar plugin (ios), it fixes at least 2 jira issues > related to hotspot/call status bar and maybe a lot of more webview > size/resize issues (will check once it's merged) > https://github.com/apache/cordova-plugin-statusbar/pull/38 > > > > 2015-11-06 2:07 GMT+01:00 Jason Ginchereau <jason...@microsoft.com>: > >> I think this PR should get in the release: >> https://github.com/apache/cordova-plugin-file/pull/146 >> It might be considered a blocker, because it is a regression that could >> cause loss of data when upgrading apps which relied on the default >> AndroidPersistentFileLocation value. >> >> This would be a good one also, as it fixes a significant failure working >> with some kinds of files on Android 5.0: >> https://github.com/apache/cordova-plugin-file/pull/119 >> >> Jason >> >> -----Original Message----- >> From: Steven Gill [mailto:stevengil...@gmail.com] >> Sent: Thursday, November 5, 2015 3:09 PM >> To: dev@cordova.apache.org >> Subject: [DISCUSS] Plugins release >> >> I plan on starting a plugins release on Monday. It is going to be a big >> one. >> >> Please review and close as many PRs as you can before than. >> >> If you have PR that is ready and needs someone to look at + merge, please >> share it in this thread and we will try to get to it before the release. >> You could also share it on slack[1] in the #plugins channel. >> >> Let me know if we have any blockers. >> >> Cheers, >> -Steve >> >> >> [1] >> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fslack.cordova.io&data=01%7c01%7cjasongin%40microsoft.com%7c6bb15854633242978d6208d2e636167f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=QY3Nj3rIJVCSOuncqfAqTul2GKH9L0Z7FQ3oaln4vg4%3d >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
