With plugin changes, it is always nice to get reviews since it could affect every platform.
file:146 is merged file: 119 LGTM Statusbar: 38 could use a review by iOS experts Keep em coming in! -Steve On Fri, Nov 6, 2015 at 5:53 AM, Simon MacDonald <simon.macdon...@gmail.com> wrote: > I agree with Jason, > https://github.com/apache/cordova-plugin-file/pull/146 should be > merged. > > Simon Mac Donald > http://hi.im/simonmacdonald > > On Thu, Nov 5, 2015 at 8:07 PM, Jason Ginchereau <jason...@microsoft.com> > wrote: > > I think this PR should get in the release: > https://github.com/apache/cordova-plugin-file/pull/146 > > It might be considered a blocker, because it is a regression that could > cause loss of data when upgrading apps which relied on the default > AndroidPersistentFileLocation value. > > > > This would be a good one also, as it fixes a significant failure working > with some kinds of files on Android 5.0: > https://github.com/apache/cordova-plugin-file/pull/119 > > > > Jason > > > > -----Original Message----- > > From: Steven Gill [mailto:stevengil...@gmail.com] > > Sent: Thursday, November 5, 2015 3:09 PM > > To: dev@cordova.apache.org > > Subject: [DISCUSS] Plugins release > > > > I plan on starting a plugins release on Monday. It is going to be a big > one. > > > > Please review and close as many PRs as you can before than. > > > > If you have PR that is ready and needs someone to look at + merge, > please share it in this thread and we will try to get to it before the > release. > > You could also share it on slack[1] in the #plugins channel. > > > > Let me know if we have any blockers. > > > > Cheers, > > -Steve > > > > > > [1] > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fslack.cordova.io&data=01%7c01%7cjasongin%40microsoft.com%7c6bb15854633242978d6208d2e636167f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=QY3Nj3rIJVCSOuncqfAqTul2GKH9L0Z7FQ3oaln4vg4%3d > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
