So instead of plugin authors including gradle files, they would just add the <preference/> to the plugin.xml and be done?
I assume this requires a platform update. Do we miss anything from not including a version as in <dependency/> way? If we just ask plugin authors to add a dependency on cordova-support-google-services doesn't that mean that the android platform wouldn't need to change? @purplecabbage risingj.com On Fri, Apr 20, 2018 at 12:04 PM, Simon MacDonald <simon.macdon...@gmail.com > wrote: > Hey all, > > I'd like to suggest that we add a new Android preference. It would be a > boolean preference, to control whether or not to run the Google Services > Plugin. > > A number of plugins need to have this gradle plugin run during build time > and they are handling it via a gradle file included in their plugin like > this: > > https://github.com/fechanique/cordova-plugin-fcm/blob/ > master/src/android/FCMPlugin.gradle > > but that falls down if two plugins try to apply GoogleServicesPlugin. > > The way to mitigate that right now is to have dependency on > cordova-support-google-services so it will only run once. > > <dependency id="cordova-support-google-services" version="~1.1.0"/> > > However, it makes sense for this to be a preference in cordova-android. > Perhaps, > > <preference name="android-RunGoogleServicesPlugin" value="true"/> > > If the value is true, then we apply the GoogleServicesPlugin. > > Simon Mac Donald > http://simonmacdonald.com >
