On 2018/04/20 19:49:11, Simon MacDonald <simon.macdon...@gmail.com> wrote: > No, I thought I'd start a discussion first. > > Simon Mac Donald > http://simonmacdonald.com > > On Fri, Apr 20, 2018 at 3:41 PM, Joe Bowser <bows...@gmail.com> wrote: > > > Is there a PR ready for this to land? > > > > On Fri, Apr 20, 2018 at 12:04 PM, Simon MacDonald < > > simon.macdon...@gmail.com > > > wrote: > > > > > Hey all, > > > > > > I'd like to suggest that we add a new Android preference. It would be a > > > boolean preference, to control whether or not to run the Google Services > > > Plugin. > > > > > > A number of plugins need to have this gradle plugin run during build time > > > and they are handling it via a gradle file included in their plugin like > > > this: > > > > > > https://github.com/fechanique/cordova-plugin-fcm/blob/ > > > master/src/android/FCMPlugin.gradle > > > > > > but that falls down if two plugins try to apply GoogleServicesPlugin. > > > > > > The way to mitigate that right now is to have dependency on > > > cordova-support-google-services so it will only run once. > > > > > > <dependency id="cordova-support-google-services" version="~1.1.0"/> > > > > > > However, it makes sense for this to be a preference in cordova-android. > > > Perhaps, > > > > > > <preference name="android-RunGoogleServicesPlugin" value="true"/> > > > > > > If the value is true, then we apply the GoogleServicesPlugin. > > > > > > Simon Mac Donald > > > http://simonmacdonald.com > > > > > > Just submitted PR at https://github.com/apache/cordova-android/pull/438
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
