Heya Alex, I went through all commits in the branch and cleaned up a few language and grammar nits that I just committed. Overall this is totally awesome, thanks so much for your effort!
You imported a few parts from guide.couchdb.org and a blog post by Christopher Lenz. We need to make sure to attribute these correctly in our NOTICE file. For the guide, there isn’t a big issue, we just need to mention its Creative Commons license and we best just email Christopher and ask if he’s cool with adding his post. Are there any other external sources you borrowed from? FWIW, I wrote a follow up on “CouchDB Joins” a few years later: https://gist.github.com/janl/6292622 feel free to copy anything from there :) Once NOTICE is up to date, I feel comfortable to merge this into master. Again, great job, thanks! Best Jan -- On Aug 19, 2013, at 12:35 , Alexander Shorin <[email protected]> wrote: > On Sun, Aug 18, 2013 at 8:02 PM, Dirkjan Ochtman <[email protected]> wrote: >> On Fri, Aug 9, 2013 at 11:10 AM, Alexander Shorin <[email protected]> wrote: >>> Hope to finish some few base things till 1.4 votes (thanks for Dirkjan >>> vacations, it's not too late for docs updates, right?) before merge >>> it. >> >> I'd like to do a thorough review of your branch, ideally before it >> gets merged (though it might not matter much). > > Sure, will be glad you for that(: > > I'll push final updates today at night, but they don't changes current stuff. > > -- > ,,,^..^,,,
signature.asc
Description: Message signed with OpenPGP using GPGMail
