On Sun, 2 Dec 2018, at 23:49, Joan Touzet wrote: > Thanks Dave - with your +1, the build passes, though I'll wait another > 36-48 hours before calling it. Would like some of our Cloudant friends > to chime in ;) > > > We have -RC1 in all the couchdb-related deps (fabric, global_changes > > etc) does this matter? I thought we squashed that in 2.1 or 2.2 > > already, and the tarball only needed to be renamed? > > > > apache-couchdb-2.3.0> l rel/couchdb/lib/ > > total 0 > > drwxr-xr-x 4 dch wheel 128B Dec 2 21:53 asn1-5.0.7/ > > drwxr-xr-x 4 dch wheel 128B Dec 2 21:53 b64url-1.0.1/ > > drwxr-xr-x 3 dch wheel 64B Dec 2 21:53 bear-0.8.1-9-g008f48a/ > > drwxr-xr-x 5 dch wheel 192B Dec 2 21:53 chttpd-2.3.0-RC1/ > > drwxr-xr-x 3 dch wheel 64B Dec 2 21:53 compiler-7.2.6/ > > drwxr-xr-x 3 dch wheel 64B Dec 2 21:53 config-2.1.4/ > > drwxr-xr-x 3 dch wheel 64B Dec 2 21:53 couch_epi-2.3.0-RC1/ > > drwxr-xr-x 3 dch wheel 64B Dec 2 21:53 couch_event-2.3.0-RC1/ > > ... > > > > IMO it's not worth re-rolling the release for this. > > Yeah, I thought we fixed this in 2.1.2/2.2.0 as well. I'm surprised > that it built like this. If you can look into it, and it's an easy > fix, I'm happy to push an -RC2 with the fix...or we can leave it like > this for 2.3.0 and push a fix for 2.3.1/2.4.0. I also don't think it's > worth re-rolling the release just for this minor thing. > > -Joan
TLDR the issue comes from `{vsn, git}` in the `.app.src` files, which is then propagated into the tarball. Normally, rebar does this, but we do it in build-aux/couchdb-build-release.sh, without re-using the variables created in the Makefile. I'll throw a patch on github for this. A+ Dave