ottlinger commented on code in PR #233: URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564196856
########## apache-rat-core/src/main/java/org/apache/rat/configuration/XMLConfigurationReader.java: ########## @@ -279,14 +334,13 @@ private ILicense parseLicense(Node licenseNode) { StringBuilder notesBuilder = new StringBuilder(); nodeListConsumer(licenseNode.getChildNodes(), x -> { if (x.getNodeType() == Node.ELEMENT_NODE) { - if (x.getNodeName().equals(NOTE)) { + if (NOTE.equals(x.getNodeName())) { notesBuilder.append(x.getTextContent()).append("\n"); Review Comment: Would System.lineSeparator() be more correct here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org