ottlinger commented on code in PR #233:
URL: https://github.com/apache/creadur-rat/pull/233#discussion_r1564217809
##########
apache-rat-core/src/main/java/org/apache/rat/configuration/builders/SpdxBuilder.java:
##########
@@ -32,22 +31,22 @@ public class SpdxBuilder extends AbstractBuilder {
/**
* sets the name for the SPDX matcher
- * @param name
- * @return
+ * @param name The text that follows the colon ':' in the SPDX tag.
+ * @return this builder for chaining.
*/
public SpdxBuilder setName(String name) {
- Objects.requireNonNull(name, "name must not be null");
+ Objects.requireNonNull(name, "spdx name must not be null");
Review Comment:
Does SPDX require uppercasing, if so we could enforce it here and in the
constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
