Claudenw commented on PR #240: URL: https://github.com/apache/creadur-rat/pull/240#issuecomment-2079782431
Well this blew up to something bigger than I wanted but... I added default exclusion for "*.json" files in the Default class and used that to configure the ReportConfiguration defaults. In the future the default exclusions should be configured in Default class. I changed the parameter names and instance variables to "filesToIgnore" and "directoriesToIgnore" to make it clear what the filters were doing. I cleaned up the DirectoryWalker and Walker classes. I ensured that the filesToIgnore and directoriesToIgnore alwasy have a value (not null). If set to null in the configuration the value is translated into a filter that always returns false. I think there may be an issue in the directoreisToIgnore processing, but it has been there from the beginning. I will investigate and open a ticket if necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
