Claudenw commented on code in PR #240:
URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1582025702
##########
apache-rat-core/src/main/java/org/apache/rat/Defaults.java:
##########
@@ -57,6 +62,10 @@ public class Defaults {
public static final String UNAPPROVED_LICENSES_STYLESHEET =
"org/apache/rat/unapproved-licenses.xsl";
private final LicenseSetFactory setFactory;
+
+ private final FilenameFilter filesToIgnore =
WildcardFileFilter.builder().setWildcards("*.json").setIoCase(IOCase.INSENSITIVE).get();
+
+ private final IOFileFilter directoriesToIgnore =
NameBasedHiddenFileFilter.HIDDEN;
Review Comment:
Defaults is intended to be the System defaults for the ReportConfiguration.
There are some cases where the report option has to be set by the UI before the
Defaults can be tested. And there is a flag for no defaults so the Defaults
need to be specified outside of the ReportConfiguration initialization.
I changed the description of Defaults and updated the values and methods to
be static.
I also added a checklist at the top of this ticket to track the things we
need to update as I suspect it it going to get longish. Feel free to add to
it. I think items on the list can be closed if we account for them in this
change or open a ticket to track them for a new change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
