ottlinger commented on code in PR #240: URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1581906153
########## apache-rat-core/src/main/java/org/apache/rat/Report.java: ########## @@ -452,11 +452,11 @@ private static IReportable getDirectory(String baseDirectory, ReportConfiguratio } if (base.isDirectory()) { - return new DirectoryWalker(base, config.getInputFileFilter(), config.getDirectoryFilter()); + return new DirectoryWalker(base, config.getFilesToIgnore(), config.getDirectoriesToIgnore()); Review Comment: DirectoryWalker would also benefit from a separate class ScanDefault .... WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org