Claudenw commented on code in PR #240:
URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1582028644
##########
apache-rat-core/src/main/java/org/apache/rat/walker/Walker.java:
##########
@@ -33,38 +34,32 @@ public abstract class Walker implements IReportable {
protected final File file;
protected final String name;
- protected final FilenameFilter filter;
+ protected final FilenameFilter filesToIgnore;
protected static FilenameFilter regexFilter(final Pattern pattern) {
return (dir, name) -> {
final boolean result;
if (pattern == null) {
- result = true;
+ result = false;
} else {
- result = !pattern.matcher(name).matches();
+ result = pattern.matcher(name).matches();
Review Comment:
I will go back and double check that this correct. However, I did change
the nomenclature to be speicfic, the list of `filesToIgnore` should indicate
that if the pattern is matched the file is excluded (same with directory).
Previously the name was `fileFilter` and there it is difficult to know if you
are including or excluding files in the filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
