Github user dragonsinth commented on a diff in the pull request:
https://github.com/apache/curator/pull/23#discussion_r15487030
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
@@ -74,7 +71,7 @@
private final NamespaceFacadeCache namespaceFacadeCache;
private final NamespaceWatcherMap namespaceWatcherMap = new
NamespaceWatcherMap(this);
- private volatile ExecutorService executorService;
+ private volatile Thread backgroundThread;
--- End diff --
The bug is simple: Executor.shutdownNow() calls FutureTask.cancel(), which
on older JDK versions has a bug where it can interrupt the wrong thread,
causing all sorts of problems. Manually interrupting a thread does not have
this problem. Given that this Executor is only every used to run one task (the
backgroundOperationsLoop) we can simply switch to a Thread and avoid that bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
