Github user dragonsinth commented on a diff in the pull request:
https://github.com/apache/curator/pull/23#discussion_r15490243
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java
---
@@ -74,7 +71,7 @@
private final NamespaceFacadeCache namespaceFacadeCache;
private final NamespaceWatcherMap namespaceWatcherMap = new
NamespaceWatcherMap(this);
- private volatile ExecutorService executorService;
+ private volatile Thread backgroundThread;
--- End diff --
Fair point, I'll revert.
BTW: I tried tracing back through the code and was not able to locate the
code path from ExecutorService.shutdownNow() -> FutureTask.cancel() under 1.6.
So I might actually be confused and thinking of a Guava executor and not a JDK
one, it's possible the JDK shutdownNow() is actually safe. If so, apologizes
for the mis-info.
Either way, CloseableExecutorService.close() probably does have the issue
since it does an explicit cancel(true).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
