Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/curator/pull/23#discussion_r15491355
--- Diff:
curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java
---
@@ -239,6 +241,16 @@ public Builder connectionTimeoutMs(int
connectionTimeoutMs)
}
/**
+ * @param closeWaitMs time to wait during close to join background
threads
--- End diff --
I think thatâs less important as itâs not visible. Up to you.
From:Â Scott Blum <[email protected]>
Reply:Â apache/curator <[email protected]>>
Date:Â July 28, 2014 at 4:13:43 PM
To:Â apache/curator <[email protected]>>
Cc:Â Jordan Zimmerman <[email protected]>>
Subject:Â Re: [curator] CURATOR-126: Fix race condition in
CuratorFrameworkImpl.close() (#23)
In
curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java:
> @@ -239,6 +241,16 @@ public Builder connectionTimeoutMs(int
connectionTimeoutMs)
> }
>
> /**
> + * @param closeWaitMs time to wait during close to join
background threads
done; what about the constant?
â
Reply to this email directly or view it on GitHub.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
