[ 
https://issues.apache.org/jira/browse/CURATOR-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996588#comment-15996588
 ] 

Enrico Olivelli commented on CURATOR-408:
-----------------------------------------

[~randgalt] 
My initial idea is to add a CuratorZookeeperClient#close(int timeoutMs) method 
which in turn will call ZooKeeper#close(int).
I will need to add such methods to ConnectionState and HandleHolder, changing 
HandleHolder#internalClose too
It this is the right direction I will submit a PR soon

Is there any other interesting attach point for the new ZooKeeper#close(int) 
method ?

> Handle graceful close of ZookKeeper client waiting for all resources to be 
> released
> -----------------------------------------------------------------------------------
>
>                 Key: CURATOR-408
>                 URL: https://issues.apache.org/jira/browse/CURATOR-408
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 3.4.0
>            Reporter: Enrico Olivelli
>
> Ths idea is to leverage the new ZooKeeper#close(timeoutMs) method introduced 
> with ZOOKEEPER-2697.
> This new method waits for the internal threads to finish, this way the client 
> is sure that all internal resources handled but low-level ZooKeeper client 
> have been released.
> This is very useful in tests because the user can wait for the test 
> environment to be cleared.
> In some cases you want to return from the 'close' method as soon as 
> possibile. In ZooKeeper a new specific method as been added in order to let 
> the user ask for a specific behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to