[ 
https://issues.apache.org/jira/browse/CURATOR-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507388#comment-16507388
 ] 

Enrico Olivelli commented on CURATOR-408:
-----------------------------------------

[~randgalt] this is my idea

[https://github.com/apache/curator/pull/266]

 

Current master fails to build I had to add a missing license header.

I need some guidance for:
 * tests...which kind of tests should I add, something with powermock, in order 
to test that actually the requested method is called on the underlying ZK 
handle ?
 * parameter name and javadocs, which is your convention ?

> Handle graceful close of ZookKeeper client waiting for all resources to be 
> released
> -----------------------------------------------------------------------------------
>
>                 Key: CURATOR-408
>                 URL: https://issues.apache.org/jira/browse/CURATOR-408
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 4.0.0
>            Reporter: Enrico Olivelli
>            Assignee: Enrico Olivelli
>            Priority: Major
>
> Ths idea is to leverage the new ZooKeeper#close(timeoutMs) method introduced 
> with ZOOKEEPER-2697.
> This new method waits for the internal threads to finish, this way the client 
> is sure that all internal resources handled but low-level ZooKeeper client 
> have been released.
> This is very useful in tests because the user can wait for the test 
> environment to be cleared.
> In some cases you want to return from the 'close' method as soon as 
> possibile. In ZooKeeper a new specific method as been added in order to let 
> the user ask for a specific behaviour.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to