[ https://issues.apache.org/jira/browse/CURATOR-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508290#comment-16508290 ]
ASF GitHub Bot commented on CURATOR-408: ---------------------------------------- Github user Randgalt commented on a diff in the pull request: https://github.com/apache/curator/pull/266#discussion_r194463357 --- Diff: curator-client/src/main/java/org/apache/curator/ConnectionState.java --- @@ -112,14 +112,17 @@ void start() throws Exception } @Override - public void close() throws IOException - { + public void close() throws IOException { + close(0); + } + + public void close(int timeout) throws IOException { --- End diff -- please rename to `timeoutMs` > Handle graceful close of ZookKeeper client waiting for all resources to be > released > ----------------------------------------------------------------------------------- > > Key: CURATOR-408 > URL: https://issues.apache.org/jira/browse/CURATOR-408 > Project: Apache Curator > Issue Type: Improvement > Components: Client > Affects Versions: 4.0.0 > Reporter: Enrico Olivelli > Assignee: Enrico Olivelli > Priority: Major > > Ths idea is to leverage the new ZooKeeper#close(timeoutMs) method introduced > with ZOOKEEPER-2697. > This new method waits for the internal threads to finish, this way the client > is sure that all internal resources handled but low-level ZooKeeper client > have been released. > This is very useful in tests because the user can wait for the test > environment to be cleared. > In some cases you want to return from the 'close' method as soon as > possibile. In ZooKeeper a new specific method as been added in order to let > the user ask for a specific behaviour. -- This message was sent by Atlassian JIRA (v7.6.3#76005)