reta commented on PR #3554: URL: https://github.com/apache/cxf/pull/3554#issuecomment-6065194188
Thanks @vp340 > About [#3555](https://github.com/apache/cxf/pull/3555/changes) the only concerne I raise is that we are introducing a different scenario based on whether U have or not Logging Feature enabled. Logging feature is an issue here - since it is very much the only one using callbacks , this is best effort here - the user will get real exception (if happen during write) or closed exception (if the stream was closed and write happens). This is merely an inconvenience (to me) vs leaking / keeping temp files. As far as could contain the change (in the LoggingOutputStream) and CacheAndWriteOutputStream proven to not cause issues - we should be fine (in my opinion). Thanks a lot for help @vp340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
