jadams-tresys commented on a change in pull request #16: Implemented packed
binary formats
URL: https://github.com/apache/incubator-daffodil/pull/16#discussion_r163260191
##########
File path:
daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/processors/parsers/PackedBinaryTraits.scala
##########
@@ -101,7 +100,7 @@ abstract class PackedBinaryIntegerBaseParser(
val int = toBigInteger(dis.getByteArray(nBits, start))
start.simpleElement.overwriteDataValue(int)
Review comment:
BCD relies on using the default value. PackedBinaryIntegerBaseParser is the
base parser for all three packed formats integer parsers. I know the naming I
used here might be a bit confusing, but the spec also uses "packed" to refer to
packed decimal, bcd, and ibm4690Packed formats. I figured PackedBinary was a
good compromise for something that all 3 formats use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
