mbeckerle commented on a change in pull request #162: Properly handle malformed
binding files
URL: https://github.com/apache/incubator-daffodil/pull/162#discussion_r246178015
##########
File path: daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala
##########
@@ -627,7 +630,22 @@ object Main extends Logging {
val extVarBindingNodeOpt = (configNode \
"externalVariableBindings").headOption
extVarBindingNodeOpt match {
case None => Seq.empty
- case Some(extVarBindingsNode) =>
ExternalVariablesLoader.getVariables(extVarBindingsNode, tunables)
+ case Some(extVarBindingsNode) => {
+ try {
+ ExternalVariablesLoader.getVariables(extVarBindingsNode,
tunables)
+ } catch {
+ case qupe: QNameUndefinedPrefixException => {
Review comment:
Shoudl be a base class or base trait here. This code doesn't really need to
know what kinds of exceptions can come out of the variable bindings, only that
one did.
Your message in the second warning should be generic "Exception when
processing external variable binding file".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
