mbeckerle commented on a change in pull request #162: Properly handle malformed
binding files
URL: https://github.com/apache/incubator-daffodil/pull/162#discussion_r246176572
##########
File path: daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala
##########
@@ -238,8 +238,11 @@ class CLIConf(arguments: Array[String]) extends
scallop.ScallopConf(arguments)
})
def qnameConvert(s: String): RefQName = {
- val eQN = QName.refQNameFromExtendedSyntax(s)
- eQN.get
+ val eQN = QName.refQNameFromExtendedSyntax(s).recover {
+ case e: Throwable => throw e
Review comment:
This seems like a no-op. If you don't have the recover, it should propagate
this throwable exactly as this does.
So if you want this, as a place to put a breakpoint, add a comment to that
effect. Or take this out once done debugging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
