mbeckerle commented on a change in pull request #162: Properly handle malformed
binding files
URL: https://github.com/apache/incubator-daffodil/pull/162#discussion_r246178469
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaSet.scala
##########
@@ -472,7 +472,12 @@ final class SchemaSet(
}
val newNS = matchingDVs.head.namespace
- val newBinding = Binding(v.varQName.local, Some(newNS), v.varValue)
+ val newBinding = try {
+ Binding(v.varQName.local, Some(newNS), v.varValue)
+ } catch {
+ case qupe: QNameUndefinedPrefixException => this.SDE("Undefined QName
prefix in externally defined variable %s: %s", v.varQName, qupe.getMessage)
Review comment:
Same here. You shouolnd't have to have two cases here. Just one for a
base-class/base trait.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
