bsloane1650 commented on a change in pull request #240: Add
dfdlx:choiceBranchKeyRanges
URL: https://github.com/apache/incubator-daffodil/pull/240#discussion_r295859659
##########
File path:
daffodil-lib/src/main/scala/org/apache/daffodil/cookers/Cookers.scala
##########
@@ -84,3 +89,28 @@ object ChoiceBranchKeyCooker extends
ListOfStringLiteralNonEmptyNoCharClassEntit
object RepValueCooker extends
ListOfStringLiteralNonEmptyNoCharClassEntitiesNoByteEntities()
object UpperCaseTokenCooker extends UpperCaseToken
+
+object IntRangeCooker extends Converter[String, Seq[Range[BigInt]]] {
+ protected def convert(input: String, context: ThrowsSDE, forUnparse:
Boolean): Seq[Range[BigInt]] = {
Review comment:
Maybe. All the other cookers are defined in EntityReplacer.scala. That file
has already seen a bit of scope creep, as some of the cookers go beyond simply
replacing entities, but this new cooker seems to be marginally farther away
from anything that can be thought of as an "entityReplacer"
Additionally, I do not have a good name to give the guts of this if I move
them to EntityReplacer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
