bsloane1650 commented on a change in pull request #240: Add
dfdlx:choiceBranchKeyRanges
URL: https://github.com/apache/incubator-daffodil/pull/240#discussion_r295862146
##########
File path:
daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/DFDL_part2_attributes.xsd
##########
@@ -108,6 +108,7 @@
<xsd:attribute name="encodingErrorPolicy"
type="dfdl:EncodingErrorPolicyEnum"/>
<xsd:attribute name="ignoreCase" type="dfdl:YesNoEnum" />
<xsd:attribute name="choiceBranchKey" type="dfdl:ListOfDFDLStringLiteral"
/>
+ <xsd:attribute ref="dfdlx:choiceBranchKeyRanges" />
Review comment:
I don't actually think the scala code explicitly validates this. I believe
it assumes that it is an int then checks the more subtle requirements (even
length and min<max). Without this change, I suspect giving it a non-integer
would results in an unhandled exeption.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
