bsloane1650 commented on a change in pull request #240: Add dfdlx:choiceBranchKeyRanges URL: https://github.com/apache/incubator-daffodil/pull/240#discussion_r295875179
########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ChoiceCombinator.scala ########## @@ -34,9 +34,10 @@ import scala.util.Failure import scala.util.Success import scala.math.BigInt import org.apache.daffodil.cookers.RepValueCooker -import org.apache.daffodil.processors.RangeBound Review comment: I think we just ignore the ranges. In theory, you could still have non-integer keys; and if you don't you will fail fail with a dispatch error. I'll file a seperate bug report for this. I would prefer not trying to sneak unrelated changes in. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
