stevedlawrence commented on a change in pull request #273: WIP: Add User 
Defined Functions Capability
URL: https://github.com/apache/incubator-daffodil/pull/273#discussion_r331634572
 
 

 ##########
 File path: 
daffodil-test/src/test/java/org/goodudfs/example/StringFunctions/StringFunctionsProvider.java
 ##########
 @@ -0,0 +1,25 @@
+package org.goodudfs.example.StringFunctions;
+
+import org.apache.daffodil.udf.*;
+
+public class StringFunctionsProvider extends UDFunctionProvider {
+       public StringFunctionsProvider() {
+               super.setFunctionClasses( new Class<?>[] { Replace.class, 
Compare.class } );
+       }
+
+       public Object lookupFunctionClass(String namespace, String name) {
+               Object functionClass = null;
+
+               String nn = String.join("_", namespace, name);
+
+               switch (nn) {
+               case "com.ext.UDFunction.StringFunctions_replace":
 
 Review comment:
   I meant at UDF compile time. If we go the annotation route, I assume that 
Java will fail to compile if the annotation doesn't have the name/namespace 
proeprties? If we go the static member route, then we can't tell until we try 
to compile the schema. Not sure if that's a big win though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to