stevedlawrence commented on a change in pull request #273: WIP: Add User Defined Functions Capability URL: https://github.com/apache/incubator-daffodil/pull/273#discussion_r334020445
########## File path: daffodil-test/src/test/java/org/goodudfs/example/StringFunctions/Compare.java ########## @@ -0,0 +1,19 @@ +package org.goodudfs.example.StringFunctions; + +import java.io.Serializable; + +import org.apache.daffodil.udf.FunctionClassInfo; + +@FunctionClassInfo( + name = "compare", + namespace = "http://goodudfs.StringFunctions"; +) +public class Compare implements Serializable { Review comment: Makes sense to me. I do like the idea of enforcing that a UDF impelments a UserDefineFunction interface, even if it's empty. It would likely mean we could have places in code where the type is UserDefinedFunction rather than Object. Functionally does mean much, but probably makes the code clear and more readable. And it gives us a place to hang required/abstract functions if we decide they are needed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
