Taking this back here ;-)
I wasn't able to easily reproduce the errors ... after opening my IDE again and
re-running the commands they succeed.
I do remember them complaining about missing ";" characters in some script.
Regarding the license text:
You do mention the licenses in the LICENSE file, however it's a usually policy
to have the full text of each license used available in the repo. You do
fulfill that by having it where you have it, however it would be nicer to have
it where someone would find it easier.
But in the end ... it's no big deal. After all, I did vote +1 ;)
The maven plugins allow keeping only the addition to the NOTICE and LICENSE
files in separate files. So at build time the default template is used and the
custom stuff is appended.
Here too this is not something crucial. I just thought: Gee this must be
annoying when releasing.
Chris
Am 12.11.20, 13:56 schrieb "Steve Lawrence" <slawre...@apache.org>:
Thanks for the vote!
About the issues:
> - GPG signature has no trust chain
I've been to a couple signing parties, but unfortunately haven't yet
gotten verified by too many people yet. Still working on it.
> - No RELEASE_NOTES
We keep our release notes on each individual release page:
https://daffodil.apache.org/releases/3.0.0
Gives us more control over formatting, like linking to bugs, and the
ability to update if we realize we forgot a note. Can't really do that
if it's in the source releases.
> - running "sbt it:test" fails
> - running "sbt daffodil-cli/stage" fails
> - running "sbt clean coverage test it:test" fails (giving up now)
It would be helpful if you could post the failures on our dev list. I
suspect the issue has to do with Java 13. We have one bug report about
OpenJDK 13, and I think that might affect the above commands:
https://issues.apache.org/jira/browse/DAFFODIL-2332
> - running "sbt ratCheck" fails
This too would be useful to post the error on our dev list. We have a
pull request that that should fix one known issue with ratCheck.
Hopefully it's the same issue.
> - It would be cool, if you could remove all of the ".keep" files (most
are no longer needed and they do extend the list of rat findings quite a
bit)
We actually have a pull request ready for the next release to fix this.
> - The sources contains license file in:
apache-daffodil-3.0.0-incubating-src/daffodil-lib/src/main/scala/passera/BSD-LICENSE.txt
this should be moved to a more prominent location (I like to put these
license texts in a "licenses" directory in the root of the project and
inside I add to the end which files in the repo it applies to)
We have passera and the contents of that license listed in our main
LICENSE file. This is here because the passera repo contents is just
copied into this directory. Since it's in the LICENSE file, I guess we
could remove it if there's confusion.
> - It appears you manually added LICENSE and NOTICE files to every
artifact in the repo (this means editing the NOTICE files for every
first release of a year. Maven has a plugin to automatically add these
to artifacts, perhaps there's an SBT way to do that too?
Some of the LICENSES and NOTICES actually have slight variations since
different artifacts include different outside sources, so we feel its
important to maintain them separately. It's not too much of a hassle to
maintain since they aren't updated very often.
On 11/12/20 4:21 AM, Christofer Dutz wrote:
> +1 (binding)
>
> Tested on my Mac using java 13 using SBT 1.3.4
>
> [OK] Download all staged artifacts under the url specified in the release
vote email into a directory we’ll now call download-dir.
> [OK] Verify the signature is correct: Additional Apache tutorial on how
to verify downloads can be found here.
> [MINOR] Check if the signature references an Apache email address.
> [OK] Verify the SHA512 hashes
> [OK] Unzip the archive
> [MINOR] Verify the existence of DISCLAIMER, LICENSE, NOTICE, README,
RELEASE_NOTES files in the extracted source bundle.
> [OK] Verify the content of DISCLAIMER, LICENSE, NOTICE, README,
RELEASE_NOTES files in the extracted source bundle.
> [OK] Run RAT externally to ensure there are no surprises.
> [OK] Search for SNAPSHOT references:
> [OK] Search for Copyright references, and if they are in headers, make
sure these files containing them are mentioned in the LICENSE file.
> [MINOR] Build the project according to the information in the README.md
file.
>
> Generally as the "compile" and "test" builds worked, I consider this a
slightly-severe-MINOR ... however you should address that ASAP.
>
> Notes:
>
> - GPG signature has no trust chain
> - No RELEASE_NOTES
> - running "sbt it:test" fails
> - running "sbt daffodil-cli/stage" fails
> - running "sbt ratCheck" fails
> - running "sbt clean coverage test it:test" fails (giving up now)
> - It would be cool, if you could remove all of the ".keep" files (most
are no longer needed and they do extend the list of rat findings quite a bit)
> - The sources contains license file in:
apache-daffodil-3.0.0-incubating-src/daffodil-lib/src/main/scala/passera/BSD-LICENSE.txt
this should be moved to a more prominent location (I like to put these license
texts in a "licenses" directory in the root of the project and inside I add to
the end which files in the repo it applies to)
> - It appears you manually added LICENSE and NOTICE files to every
artifact in the repo (this means editing the NOTICE files for every first
release of a year. Maven has a plugin to automatically add these to artifacts,
perhaps there's an SBT way to do that too?
>
>
> Am 10.11.20, 13:51 schrieb "Steve Lawrence" <slawre...@apache.org>:
>
> Remdiner to please take a look at this vote if you get a chance. We
only have two mentors so we will need at least one vote from another IPMC
member.
>
> Thanks!
>
> On 2020/11/04 16:30:28, Steve Lawrence <slawre...@apache.org> wrote:
> >
> > The Apache Daffodil community has voted and approved the proposed
> > release of Apache Daffodil (incubating) 3.0.0-rc1.
> >
> > We now kindly request the Incubator PMC members review and vote on
this
> > incubator release.
> >
> > Daffodil is an open source implementation of the DFDL specification
that
> > uses DFDL schemas to parse fixed format data into an infoset, which
is
> > most commonly represented as either XML or JSON. This allows the
use of
> > well-established XML or JSON technologies and libraries to consume,
> > inspect, and manipulate fixed format data in existing solutions.
> > Daffodil is also capable of the reverse by serializing or
"unparsing" an
> > XML or JSON infoset back to the original data format.
> >
> > Vote thread:
> >
https://lists.apache.org/thread.html/r4352b6907245d31b556d1fb977c7c7261487174f99e723c0cf77fad8%40%3Cdev.daffodil.apache.org%3E
> >
> > Result thread:
> >
https://lists.apache.org/thread.html/rb08b144b848350c6f29af0bad64570a1cc77d37d296129d26aedbe0a%40%3Cdev.daffodil.apache.org%3E
> >
> > All distribution packages, including signatures, digests, etc. can
be
> > found at:
> >
> > https://dist.apache.org/repos/dist/dev/incubator/daffodil/3.0.0-rc1/
> >
> > Staging artifacts can be found at:
> >
> >
https://repository.apache.org/content/repositories/orgapachedaffodil-1019/
> >
> > This release has been signed with PGP key 36F3494B033AE661,
corresponding
> > to slawre...@apache.org, which is included in the KEYS file here:
> >
> > https://downloads.apache.org/incubator/daffodil/KEYS
> >
> > The release candidate has been tagged in git with v3.0.0-rc1.
> >
> > For reference, here is a list of all closed JIRAs tagged with 3.0.0:
> >
> > https://s.apache.org/daffodil-issues-3.0.0
> >
> > For a summary of the changes in this release, see:
> >
> > https://daffodil.apache.org/releases/3.0.0/
> >
> > Please review and vote. The vote will be open for at least 72 hours
> > (Saturday, 07 November 2019, 12 Noon EST).
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> >
---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
