----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23751/#review48343 -----------------------------------------------------------
datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java <https://reviews.apache.org/r/23751/#comment84855> I wonder if it is worth exposing the raw query string too. Although it would be a strange query string and I'm not really sure what it means, the following would result in information loss: x=foo&y=bar&x=baz datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java <https://reviews.apache.org/r/23751/#comment84854> I'd prefer static helper methods to extract the portion from the URL that you are interested in, rather than fields in the class. datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java <https://reviews.apache.org/r/23751/#comment84856> File seems a bit too redundant, since it is derived from the path and query string. - Matthew Hayes On July 21, 2014, 6:03 p.m., Joydeep Banerjee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23751/ > ----------------------------------------------------------- > > (Updated July 21, 2014, 6:03 p.m.) > > > Review request for DataFu. > > > Repository: datafu > > > Description > ------- > > DATAFU-62 - Pig UDF for URL info > > > Diffs > ----- > > datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION > datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/23751/diff/ > > > Testing > ------- > > > Thanks, > > Joydeep Banerjee > >
