----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23751/#review48560 -----------------------------------------------------------
datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java <https://reviews.apache.org/r/23751/#comment85244> StreamingMedian isn't used datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java <https://reviews.apache.org/r/23751/#comment85246> Since Pattern is thread safe I would just create a static field to hold it so you don't have to call compile on every call. - Matthew Hayes On July 23, 2014, 8:38 p.m., Joydeep Banerjee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23751/ > ----------------------------------------------------------- > > (Updated July 23, 2014, 8:38 p.m.) > > > Review request for DataFu. > > > Repository: datafu > > > Description > ------- > > DATAFU-62 - Pig UDF for URL info > > > Diffs > ----- > > datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION > datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION > datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION > datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/23751/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > DATAFU-62-v2 > > https://reviews.apache.org/media/uploaded/files/2014/07/22/0f4ba443-4843-4fd7-a014-066b2b6378a1__DATAFU-62-v2.patch > > > Thanks, > > Joydeep Banerjee > >
