> On July 23, 2014, 10:54 p.m., Matthew Hayes wrote:
> > It looks like the diff didn't apply cleanly. Do you know why this is?
> >
> > Diff currently unavailable.
> > Error: The patch to 'datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java'
> > didn't apply cleanly. The temporary files have been left in
> > '/tmp/reviewboard.Ns3J4X' for debugging purposes. `patch` returned: The
> > next patch would create the file /tmp/reviewboard.Ns3J4X/tmpjP6xtp, which
> > already exists! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1
> > hunk ignored
Not sure. Tried another update. But looks like the problem remains.
Here's the commit log -
$ git log master..
commit 8f68d4f81103b70d77b76022fefb94e62edf6810
Author: Joydeep Banerjee <jbanerj...@gmail.com>
Date: Wed Jul 23 15:36:30 2014 -0700
Mods to the URLInfo class
commit a3be94de960a4eb00edb66aee4acb2fceb206cf1
Author: Joydeep Banerjee <jbanerj...@gmail.com>
Date: Tue Jul 22 16:02:05 2014 -0700
Modified per review comments.
commit 6216eed8918359360112f7cd3b84cf8c71b3cfd5
Author: Joydeep Banerjee <jbanerj...@gmail.com>
Date: Mon Jul 21 10:51:17 2014 -0700
Added Pig UDF for URL Info
- Joydeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23751/#review48564
-----------------------------------------------------------
On July 23, 2014, 11:23 p.m., Joydeep Banerjee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23751/
> -----------------------------------------------------------
>
> (Updated July 23, 2014, 11:23 p.m.)
>
>
> Review request for DataFu.
>
>
> Repository: datafu
>
>
> Description
> -------
>
> DATAFU-62 - Pig UDF for URL info
>
>
> Diffs
> -----
>
> datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION
> datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION
> datafu-pig/src/main/java/datafu/pig/urls/URLInfo.java PRE-CREATION
> datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION
> datafu-pig/src/test/java/datafu/test/pig/urls/URLInfoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23751/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> DATAFU-62-v2
>
> https://reviews.apache.org/media/uploaded/files/2014/07/22/0f4ba443-4843-4fd7-a014-066b2b6378a1__DATAFU-62-v2.patch
>
>
> Thanks,
>
> Joydeep Banerjee
>
>
