leerho commented on code in PR #5: URL: https://github.com/apache/datasketches-bigquery/pull/5#discussion_r1710365103
########## theta_sketch_agg_union.sql: ########## @@ -15,8 +15,17 @@ # specific language governing permissions and limitations # under the License. -CREATE OR REPLACE AGGREGATE FUNCTION `$BQ_PROJECT.$BQ_DATASET`.theta_sketch_agg_union(sketch BYTES, lg_k INT64 NOT AGGREGATE) RETURNS BYTES LANGUAGE js -OPTIONS (library=["$GCS_BUCKET/theta_sketch.mjs"]) AS R""" +CREATE OR REPLACE AGGREGATE FUNCTION `$BQ_PROJECT.$BQ_DATASET`.theta_sketch_agg_union(sketch BYTES, lg_k INT64 NOT AGGREGATE) Review Comment: This is the only one that didn't require a seed. Is this correct? ########## theta_sketch_a_not_b.sql: ########## @@ -15,8 +15,18 @@ # specific language governing permissions and limitations # under the License. -CREATE OR REPLACE FUNCTION `$BQ_PROJECT.$BQ_DATASET`.theta_sketch_a_not_b(sketch1 BYTES, sketch2 BYTES, seed INT64) RETURNS BYTES LANGUAGE js -OPTIONS (library=["$GCS_BUCKET/theta_sketch.js"]) AS R""" +CREATE OR REPLACE FUNCTION `$BQ_PROJECT.$BQ_DATASET`.theta_sketch_a_not_b(sketch1 BYTES, sketch2 BYTES, seed INT64) +RETURNS BYTES +LANGUAGE js +OPTIONS ( + library=["$GCS_BUCKET/theta_sketch.js"], + description = '''Performs the scalar set difference: sketch1 and not sketch2. +Param sketch1: the first sketch "a" as bytes. +Param sketch2: the second sketch "b" as bytes. Review Comment: I think we need to be consistent and clear just what kind of sketch "bytes" we are expecting: are these Base64 encoded bytes, or raw bytes? Do they represent a Compressed Compact Sketch, always? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
