AlexanderSaydakov commented on code in PR #5: URL: https://github.com/apache/datasketches-bigquery/pull/5#discussion_r1710566158
########## theta_sketch_agg_union.sql: ########## @@ -15,8 +15,17 @@ # specific language governing permissions and limitations # under the License. -CREATE OR REPLACE AGGREGATE FUNCTION `$BQ_PROJECT.$BQ_DATASET`.theta_sketch_agg_union(sketch BYTES, lg_k INT64 NOT AGGREGATE) RETURNS BYTES LANGUAGE js -OPTIONS (library=["$GCS_BUCKET/theta_sketch.mjs"]) AS R""" +CREATE OR REPLACE AGGREGATE FUNCTION `$BQ_PROJECT.$BQ_DATASET`.theta_sketch_agg_union(sketch BYTES, lg_k INT64 NOT AGGREGATE) Review Comment: not implemented yet. I will do that shortly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
