leerho commented on code in PR #5: URL: https://github.com/apache/datasketches-bigquery/pull/5#discussion_r1710367873
########## theta_sketch_scalar_intersection.sql: ########## @@ -15,8 +15,18 @@ # specific language governing permissions and limitations # under the License. -CREATE OR REPLACE FUNCTION `$BQ_PROJECT.$BQ_DATASET`.theta_sketch_scalar_intersection(sketchBytes1 BYTES, sketchBytes2 BYTES, seed INT64) RETURNS BYTES LANGUAGE js -OPTIONS (library=["$GCS_BUCKET/theta_sketch.js"]) AS R""" +CREATE OR REPLACE FUNCTION `$BQ_PROJECT.$BQ_DATASET`.theta_sketch_scalar_intersection(sketchBytes1 BYTES, sketchBytes2 BYTES, seed INT64) Review Comment: could we not use "sketch1" and "sketch2" as in the other set operations? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
