Github user jiazhai commented on a diff in the pull request:
https://github.com/apache/incubator-distributedlog/pull/133#discussion_r119984610
--- Diff:
distributedlog-core/src/main/java/org/apache/distributedlog/BKLogHandler.java
---
@@ -397,15 +398,15 @@ private Long sum(List<Long> values) {
}
@Override
- public Future<Void> asyncAbort() {
+ public CompletableFuture<Void> asyncAbort() {
return asyncClose();
}
- public Future<LogRecordWithDLSN> asyncReadLastUserRecord(final
LogSegmentMetadata l) {
+ public CompletableFuture<LogRecordWithDLSN>
asyncReadLastUserRecord(final LogSegmentMetadata l) {
return asyncReadLastRecord(l, false, false, false);
}
- public Future<LogRecordWithDLSN> asyncReadLastRecord(final
LogSegmentMetadata l,
+ public CompletableFuture<LogRecordWithDLSN> asyncReadLastRecord(final
LogSegmentMetadata l,
final boolean
fence,
--- End diff --
Please also do the code alignment change here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
